aokolnychyi commented on code in PR #8262:
URL: https://github.com/apache/iceberg/pull/8262#discussion_r1287791889
##########
spark/v3.4/spark-extensions/src/jmh/java/org/apache/iceberg/spark/PlanningBenchmark.java:
##########
@@ -246,18 +272,19 @@ private void initDataAndDeletes() throws
NoSuchTableException {
RowDelta rowDelta = table.newRowDelta();
for (int fileOrdinal = 0; fileOrdinal < NUM_DELETE_FILES_PER_PARTITION;
fileOrdinal++) {
+ String replicaFileName = UUID.randomUUID() + "-replica.parquet";
DeleteFile replicaDeleteFile =
- FileMetadata.deleteFileBuilder(table.spec())
+ FileMetadata.deleteFileBuilder(spec)
.copy(deleteFile)
- .withPath("replica-" + fileOrdinal + "-" + deleteFile.path())
+ .withPath(locations.newDataLocation(spec,
deleteFile.partition(), replicaFileName))
Review Comment:
Switching to more realistic file paths for replicated files to actually
validate min/max boundary checks. Previously, we added a fake prefix that never
matched the table location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
