Xuanwo commented on code in PR #20:
URL: https://github.com/apache/iceberg-rust/pull/20#discussion_r1288032808
##########
crates/iceberg/src/error.rs:
##########
@@ -44,6 +44,8 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
FeatureUnsupported,
+ /// This error is returned when we try to convert a JSON null value to an
iceberg value
Review Comment:
I believe this error kind also need to be merged into `DataInvalid`. The
action user can take is the same. `NullConversion` is more like a detail about
this error instead it's kind by which user can take actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
