liurenjie1024 commented on code in PR #25:
URL: https://github.com/apache/iceberg-rust/pull/25#discussion_r1288570375
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -438,13 +461,15 @@ impl fmt::Display for NestedField {
/// Elements can be either optional or required. Element types may be any type.
pub struct ListType {
/// Element field of list type.
- pub element_field: NestedField,
+ pub element_field: NestedFieldRef,
}
/// Module for type serialization/deserialization.
pub(super) mod _serde {
use crate::spec::datatypes::Type::Map;
- use crate::spec::datatypes::{ListType, MapType, NestedField,
PrimitiveType, StructType, Type};
+ use crate::spec::datatypes::{
+ ListType, MapType, NestedField, NestedFieldRef, PrimitiveType,
StructType, Type,
Review Comment:
Oh, I see. feature flag in rust is a tool to enable condition compilation,
and 'rc' here means generating see/de code for 'Arc', and the explanation is
here:
https://stackoverflow.com/questions/49312600/how-do-i-serialize-or-deserialize-an-arct-in-serde.
I don't know similar concepts in java/python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
