Fokko commented on code in PR #8134: URL: https://github.com/apache/iceberg/pull/8134#discussion_r1290953861
########## python/pyiceberg/avro/lazydict.py: ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import ( + Dict, + Iterator, + Mapping, + Tuple, +) + + +class LazyDictIntInt(Mapping[int, int]): Review Comment: Should we throw in some unit-tests for the lazydict? ########## python/pyproject.toml: ########## @@ -63,7 +66,7 @@ boto3 = { version = ">=1.17.106", optional = true } s3fs = { version = ">=2021.08.0,<2024.1.0", optional = true } # Upper bound set arbitrarily, to be reassessed in early 2024. adlfs = { version = ">=2021.07.0,<2024.1.0", optional = true } # Upper bound set arbitrarily, to be reassessed in early 2024. psycopg2-binary = { version = ">=2.9.6", optional = true } -sqlalchemy = { version = "^2.0.18", optional = true } +sqlalchemy = { version = "^2.0.18" } Review Comment: SQL Alchemy should only be installed when people are using the SQLCatalog. ```suggestion sqlalchemy = { version = "^2.0.18", optional = true } ``` ########## python/pyproject.toml: ########## @@ -39,7 +39,10 @@ packages = [ { include = "Makefile", format = "sdist" }, { include = "NOTICE", format = ["sdist", "wheel"] } ] -include = [{ path = "dev", format = "sdist" }] +include = [ + { path = "dev", format = "sdist" }, + { path = "pyiceberg/**/*.so", format = "wheel" } Review Comment: I pulled in this branch on top of https://github.com/apache/iceberg/pull/8287 and it worked like a charm 🥳 ########## python/pyiceberg/avro/lazydict.py: ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import ( + Dict, + Iterator, + Mapping, + Tuple, +) + + +class LazyDictIntInt(Mapping[int, int]): Review Comment: Could we generalize this one outside of Avro? If so, we could also move it to `utils/typedef.py` ########## python/pyproject.toml: ########## @@ -39,7 +39,10 @@ packages = [ { include = "Makefile", format = "sdist" }, { include = "NOTICE", format = ["sdist", "wheel"] } ] -include = [{ path = "dev", format = "sdist" }] +include = [ + { path = "dev", format = "sdist" }, + { path = "pyiceberg/**/*.so", format = "wheel" } Review Comment: I pulled in this branch on top of https://github.com/apache/iceberg/pull/8287 and it worked like a charm 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
