nastra commented on PR #8284: URL: https://github.com/apache/iceberg/pull/8284#issuecomment-1674331712
@ConeyLiu you might want to get in touch with the author of #6799 to see whether he has cycles to complete #6799. I think it would be good to have a combination of #6799 and this PR here. In particular what I like about this PR is that we just pass a configuration map to https://github.com/apache/iceberg/pull/8284/files#diff-4e8faf21494a38d340335de99357de31cdca2f3f82af495f832f67fc2446ad49R259 rather than 2 separate settings for compression. However, we should avoid breaking the API here in this PR and you might want to take a look at #6799 how it was achieved without API breakages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
