aless10 commented on code in PR #8286:
URL: https://github.com/apache/iceberg/pull/8286#discussion_r1291293948
##########
python/tests/table/test_metadata.py:
##########
@@ -76,12 +76,12 @@ def example_table_metadata_v1() -> Dict[str, Any]:
def test_from_dict_v1(example_table_metadata_v1: Dict[str, Any]) -> None:
"""Test initialization of a TableMetadata instance from a dictionary"""
- TableMetadataUtil.parse_obj(example_table_metadata_v1)
+ TableMetadataUtil.parse_raw(json.dumps(example_table_metadata_v1))
Review Comment:
Ok, but still I have to add tests for the new method. So, it's like
duplicating the test but call another method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]