dramaticlly commented on code in PR #7976:
URL: https://github.com/apache/iceberg/pull/7976#discussion_r1291636612
##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -51,16 +61,17 @@ public void
testResolvingFileIOWithHadoopFileIOKryoSerialization() throws IOExce
resolvingFileIO.setConf(conf);
resolvingFileIO.initialize(ImmutableMap.of("k1", "v1"));
-
assertThat(resolvingFileIO.ioClass(temp.toString())).isEqualTo(HadoopFileIO.class);
- assertThat(resolvingFileIO.newInputFile(temp.toString())).isNotNull();
+
assertThat(resolvingFileIO.ioClass(tempDir.getCanonicalPath())).isEqualTo(HadoopFileIO.class);
Review Comment:
thank you @nastra, it was coming from my attempt to resolve conflict and
desired to simplify the tempDir usage in unit tests. Now i replaced `tempDir`
in favor of `@TempDir private java.nio.file.Path temp` per your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
