coded9 commented on code in PR #8315:
URL: https://github.com/apache/iceberg/pull/8315#discussion_r1293251526


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -238,7 +238,8 @@ protected TableOperations newTableOps(TableIdentifier 
tableIdentifier) {
           awsProperties,
           tableSpecificCatalogPropertiesBuilder.buildOrThrow(),
           hadoopConf,
-          tableIdentifier);
+          tableIdentifier,
+          closeableGroup);

Review Comment:
   `closeableGroup.addCloseable(tableOperations.io());`
   This would create fileIO even before when it is actually needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to