szehon-ho commented on PR #8300: URL: https://github.com/apache/iceberg/pull/8300#issuecomment-1677825100
In my thought, as [build.gradle](https://github.com/apache/iceberg/blob/master/build.gradle#L58) supports building of all Java versions, it could be a surprise to jenv users that Iceberg overrides the user's global default. Also i took a brief look at some other projects like Parquet/Spark/Flink/Hive, and didn't see .java-version there. I think this made sense before when Spark 2 was not built without java8, but now that has been removed and don't see a strong reason to default Iceberg to a specific java version overriding the user's default. That being said, I can leave this a little bit and see if anyone has strong comments against its removal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
