[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #983: Convert date and timestamp values in generics

[GitBox]

rdblue commented on a change in pull request #983:
URL: https://github.com/apache/incubator-iceberg/pull/983#discussion_r417474026



##########
File path: api/src/main/java/org/apache/iceberg/Accessors.java
##########
@@ -187,6 +206,47 @@ public String toString() {
     }
   }
 
+  private static class DateAccessor extends PositionAccessor {

Review comment:
       Looks like this is the cause of the test failures:
   
   ```
   org.apache.iceberg.spark.source.TestFilteredScan > 
testDayPartitionedTimestampFilters[2] FAILED
       java.lang.IllegalArgumentException: Wrong class, java.time.LocalDate, 
for object: 17521
           at org.apache.iceberg.PartitionData.get(PartitionData.java:120)
           at org.apache.iceberg.Accessors$DateAccessor.get(Accessors.java:216)
           at org.apache.iceberg.Accessors$DateAccessor.get(Accessors.java:209)
           at 
org.apache.iceberg.expressions.BoundReference.eval(BoundReference.java:39)
   ```
   
   We need to substitute this accessor for the default accessor only when using 
Iceberg generics.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org