harshm-dev commented on issue #8331: URL: https://github.com/apache/iceberg/issues/8331#issuecomment-1680470847
Thanks for the response. This is my read - - [BaseMetastoreCatalog:registerTable](https://github.com/apache/iceberg/blob/c1fc55022557653cfeb6125c1d51bf8ab12c8f96/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L87) invokes TO.commit - [NessieTableOperations:commitTable](https://github.com/apache/iceberg/blob/c1fc55022557653cfeb6125c1d51bf8ab12c8f96/nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java#L139C7-L139C13 ) calls commitTable on the NessieIcebergClient - [NessieIcebergClient:commitTable](https://github.com/apache/iceberg/blob/c1fc55022557653cfeb6125c1d51bf8ab12c8f96/nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java#L479) finally tries to commit into Nessie. IMO we should be able to distinguish between the register and snapshot update cases by checking if the base metadata is present, and update the messages respectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
