aokolnychyi commented on code in PR #8336:
URL: https://github.com/apache/iceberg/pull/8336#discussion_r1296188011
##########
core/src/main/java/org/apache/iceberg/BaseContentScanTask.java:
##########
@@ -95,7 +95,7 @@ public Expression residual() {
@Override
public Iterable<ThisT> split(long targetSplitSize) {
if (file.format().isSplittable()) {
- if (file.splitOffsets() != null &&
OFFSET_ORDERING.isOrdered(file.splitOffsets())) {
+ if (file.splitOffsets() != null &&
OFFSET_ORDERING.isStrictlyOrdered(file.splitOffsets())) {
Review Comment:
Our `OffsetsAwareSplitScanTaskIterator` constructor below called
`isStrictlyOrdered` to ensure there are no duplicates. I am just moving this
check here as it is called for each data file being planned. No need to
validate it twice as the iterator is package-private and is only used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
