liurenjie1024 commented on PR #29: URL: https://github.com/apache/iceberg-rust/pull/29#issuecomment-1683309637
It seems that the `V1`/`V2` suffix is not clear enough to show that they are only used for making ser/de easier to write, and caused some misunderstanding for reviewers. I would suggest two improvements: 1. Move structs for serde into private modules such as `_serde` 2. Add comments to explain that these are only for format conversion, not user facing api. cc @JanKaul @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
