ZENOTME commented on issue #34:
URL: https://github.com/apache/iceberg-rust/issues/34#issuecomment-1684917586
## More detail SpecificFormatWriter interface design
I think there is enough info to have a SpecificFormatWriter interface
design. (May be we can call it FileWriter). If following interface looks well,
I will introduce a PR to make it work first!
```
enum WriterConfig {
Parquet(ParquetWriterConfig),
Avro(AvroWriterConfig)
}
enum FileWriter {
Parquet(ParquetFileWriter)
Avro(AvroWriter)
}
impl FileWriter {
/// Create the writer according to config
fn try_new(writer: impl AsynWriter, schema: ArrowSchemaRef,
config:WriterConfig) -> Self;
async fn write(record_batach) -> Result<()>;
async fn close() -> Result<DataFile>
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
