nastra commented on code in PR #8366:
URL: https://github.com/apache/iceberg/pull/8366#discussion_r1301882759
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -71,6 +74,12 @@ public class HTTPClient implements RESTClient {
@VisibleForTesting
static final String CLIENT_GIT_COMMIT_SHORT_HEADER =
"X-Client-Git-Commit-Short";
+ private static final String RETRY_STRATEGY = "rest.client.retry-strategy";
+ private static final String REST_MAX_RETRIES = "rest.client.max-retries";
+ private static final String REST_RETRY_INTERVAL_MILLIS =
"rest.client.retry-interval-millis";
Review Comment:
I'm ok either way, I just figured that having `client` in there makes it
slightly more clear that we're targeting the REST HTTP client. Alternatively we
could use `rest.http.max-retries`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
