HonahX commented on code in PR #8398:
URL: https://github.com/apache/iceberg/pull/8398#discussion_r1306332038
##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -74,31 +72,22 @@ public class TestSnapshotDeltaLakeTable extends
SparkDeltaLakeSnapshotTestBase {
private static final String NAMESPACE = "delta_conversion_test";
private static final String defaultSparkCatalog = "spark_catalog";
private static final String icebergCatalogName = "iceberg_hive";
+ private static final Map<String, String> config =
+ ImmutableMap.of(
+ "type", "hive",
+ "default-namespace", "default",
+ "parquet-enabled", "true",
+ "cache-enabled",
+ "false" // Spark will delete tables using v1, leaving the cache
out of sync
+ );
private static Dataset<Row> typeTestDataFrame;
private static Dataset<Row> nestedDataFrame;
- static Stream<Arguments> parameters() {
- return Stream.of(
- Arguments.of(
- icebergCatalogName,
- SparkCatalog.class.getName(),
- ImmutableMap.of(
- "type",
- "hive",
- "default-namespace",
- "default",
- "parquet-enabled",
- "true",
- "cache-enabled",
- "false" // Spark will delete tables using v1, leaving the
cache out of sync
- )));
- }
-
- @TempDir private Path temp;
+ @TempDir private File tempA;
+ @TempDir private File tempB;
- public TestSnapshotDeltaLakeTable(
- String catalogName, String implementation, Map<String, String> config) {
- super(catalogName, implementation, config);
+ public TestSnapshotDeltaLakeTable() {
+ super(icebergCatalogName, SparkCatalog.class.getName(), config);
Review Comment:
Junit5 cannot parametrize class creation. Since we only have one set of
parameters in junit4 version, I think we can directly feed them into super
class.
##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -74,31 +72,22 @@ public class TestSnapshotDeltaLakeTable extends
SparkDeltaLakeSnapshotTestBase {
private static final String NAMESPACE = "delta_conversion_test";
private static final String defaultSparkCatalog = "spark_catalog";
private static final String icebergCatalogName = "iceberg_hive";
+ private static final Map<String, String> config =
+ ImmutableMap.of(
+ "type", "hive",
+ "default-namespace", "default",
+ "parquet-enabled", "true",
+ "cache-enabled",
+ "false" // Spark will delete tables using v1, leaving the cache
out of sync
+ );
private static Dataset<Row> typeTestDataFrame;
private static Dataset<Row> nestedDataFrame;
- static Stream<Arguments> parameters() {
- return Stream.of(
- Arguments.of(
- icebergCatalogName,
- SparkCatalog.class.getName(),
- ImmutableMap.of(
- "type",
- "hive",
- "default-namespace",
- "default",
- "parquet-enabled",
- "true",
- "cache-enabled",
- "false" // Spark will delete tables using v1, leaving the
cache out of sync
- )));
- }
-
- @TempDir private Path temp;
+ @TempDir private File tempA;
+ @TempDir private File tempB;
- public TestSnapshotDeltaLakeTable(
- String catalogName, String implementation, Map<String, String> config) {
- super(catalogName, implementation, config);
+ public TestSnapshotDeltaLakeTable() {
+ super(icebergCatalogName, SparkCatalog.class.getName(), config);
Review Comment:
Junit5 cannot parametrize class creation. Since we only have one set of
parameters in junit4 version, I think we can directly feed them into super
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
