rdblue commented on code in PR #8446:
URL: https://github.com/apache/iceberg/pull/8446#discussion_r1311905968
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java:
##########
@@ -161,10 +161,13 @@ public static Expression convert(Filter filter) {
case IN:
In inFilter = (In) filter;
+ Preconditions.checkArgument(
+ Stream.of(inFilter.values()).noneMatch(Objects::isNull),
+ "Expression can not be converted (in is not null-safe): %s",
+ filter);
Review Comment:
This should return null, not throw an exception. We don't ever want to fail
conversion, just return `null` so the caller doesn't push an expression down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
