amogh-jahagirdar commented on code in PR #8392:
URL: https://github.com/apache/iceberg/pull/8392#discussion_r1312435019
##########
spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSetCurrentSnapshotProcedure.java:
##########
@@ -219,14 +220,14 @@ public void testInvalidRollbackToSnapshotCases() {
AssertHelpers.assertThrows(
"Should reject calls without all required args",
- AnalysisException.class,
- "Missing required parameters",
+ IllegalArgumentException.class,
+ "Either snapshot_id or ref must be provided, not both",
Review Comment:
This error message doesn't seem right for the arguments that are being
passed in. We're missing the required parameters right? Also I don't think we
should change the exception that is being thrown for the existing cases
(missing required parameters) because we probably want to preserve that
behavior in case users rely on it. For the new failure case (ref + snapshot ID)
the IllegalArgumentException is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
