rustyconover commented on code in PR #8304: URL: https://github.com/apache/iceberg/pull/8304#discussion_r1315216886
########## python/pyiceberg/catalog/glue.py: ########## @@ -56,124 +64,109 @@ from pyiceberg.table.sorting import UNSORTED_SORT_ORDER, SortOrder from pyiceberg.typedef import EMPTY_DICT -BOTO_SESSION_CONFIG_KEYS = ["aws_access_key_id", "aws_secret_access_key", "aws_session_token", "region_name", "profile_name"] - -GLUE_CLIENT = "glue" - - -PROP_GLUE_TABLE = "Table" -PROP_GLUE_TABLE_TYPE = "TableType" -PROP_GLUE_TABLE_DESCRIPTION = "Description" -PROP_GLUE_TABLE_PARAMETERS = "Parameters" -PROP_GLUE_TABLE_DATABASE_NAME = "DatabaseName" -PROP_GLUE_TABLE_NAME = "Name" -PROP_GLUE_TABLE_OWNER = "Owner" -PROP_GLUE_TABLE_STORAGE_DESCRIPTOR = "StorageDescriptor" Review Comment: I think mypy sufficiently protects against typos. Having variables with literal strings doesn't seem very useful to me, I prefer just to rely on the types defined by mypy_boto3_glue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
