rdblue commented on code in PR #7880:
URL: https://github.com/apache/iceberg/pull/7880#discussion_r1315217698
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -312,4 +325,182 @@ private MetricsReporter metricsReporter() {
return metricsReporter;
}
+
+ protected ViewOperations newViewOps(TableIdentifier identifier) {
+ throw new UnsupportedOperationException("Not implemented: newViewOps");
+ }
+
+ @Override
+ public List<TableIdentifier> listViews(Namespace namespace) {
+ throw new UnsupportedOperationException("Not implemented: listViews");
+ }
+
+ @Override
+ public View loadView(TableIdentifier identifier) {
+ View result;
+ if (isValidIdentifier(identifier)) {
+ ViewOperations ops = newViewOps(identifier);
+ if (ops.current() == null) {
+ throw new NoSuchViewException("View does not exist: %s", identifier);
+ } else {
+ result = new BaseView(newViewOps(identifier), fullTableName(name(),
identifier));
+ }
+ } else {
+ throw new NoSuchViewException("Invalid view identifier: %s", identifier);
+ }
+
+ LOG.info("View loaded by catalog: {}", result);
+ return result;
+ }
+
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ throw new UnsupportedOperationException("Not implemented: dropView");
+ }
+
+ @Override
+ public void renameView(TableIdentifier from, TableIdentifier to) {
+ throw new UnsupportedOperationException("Not implemented: renameView");
+ }
+
+ @Override
+ public ViewBuilder buildView(TableIdentifier identifier) {
+ return new BaseViewBuilder(identifier);
+ }
+
+ protected class BaseViewBuilder implements ViewBuilder {
+ private final TableIdentifier identifier;
+ private final ImmutableViewVersion.Builder viewVersionBuilder =
ImmutableViewVersion.builder();
+ private final List<ViewRepresentation> viewRepresentations =
Lists.newArrayList();
+ private Schema schema;
+ private final Map<String, String> properties = Maps.newHashMap();
+
+ public BaseViewBuilder(TableIdentifier identifier) {
+ Preconditions.checkArgument(
+ isValidIdentifier(identifier), "Invalid view identifier: %s",
identifier);
+ this.identifier = identifier;
+ }
+
+ @Override
+ public ViewBuilder withSchema(Schema newSchema) {
+ this.schema = newSchema;
+ viewVersionBuilder.schemaId(newSchema.schemaId());
+ return this;
+ }
+
+ @Override
+ public ViewBuilder withQuery(String dialect, String sql) {
+ viewRepresentations.add(
+
ImmutableSQLViewRepresentation.builder().dialect(dialect).sql(sql).build());
+ return this;
+ }
+
+ @Override
+ public ViewBuilder withDefaultCatalog(String catalog) {
+ viewVersionBuilder.defaultCatalog(catalog);
+ return this;
+ }
+
+ @Override
+ public ViewBuilder withDefaultNamespace(Namespace namespace) {
+ viewVersionBuilder.defaultNamespace(namespace);
+ return this;
+ }
+
+ @Override
+ public ViewBuilder withProperties(Map<String, String> newProperties) {
+ this.properties.putAll(newProperties);
+ return this;
+ }
+
+ @Override
+ public ViewBuilder withProperty(String key, String value) {
+ this.properties.put(key, value);
+ return this;
+ }
+
+ @Override
+ public View create() {
+ ViewOperations ops = newViewOps(identifier);
+ if (null != ops.current()) {
+ throw new AlreadyExistsException("View already exists: %s",
identifier);
+ }
+
+ long timestampMillis = System.currentTimeMillis();
+
+ ViewVersion viewVersion =
+ viewVersionBuilder
+ .versionId(1)
+ .addAllRepresentations(viewRepresentations)
+ .timestampMillis(timestampMillis)
+ .putSummary("operation", "create")
+ .build();
+
+ ViewMetadata.Builder builder =
+ ViewMetadata.builder()
+ .setProperties(properties)
+ .setLocation(defaultWarehouseLocation(identifier));
+
+ if (null != schema) {
+ builder.addSchema(schema);
+ }
+
+ ViewMetadata viewMetadata =
+
builder.addVersion(viewVersion).setCurrentVersionId(viewVersion.versionId()).build();
Review Comment:
This needs to use `setCurrentVersion(viewVersion, schema)` instead. That's
how versions should be added through the `ViewMetadata` API. The `addVersion`
and `setCurrentVersionId` methods are for the parser because they depend on the
version ID not being reassigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
