atifiu commented on code in PR #8517:
URL: https://github.com/apache/iceberg/pull/8517#discussion_r1318465020


##########
docs/configuration.md:
##########
@@ -74,7 +74,7 @@ Iceberg tables support table properties to configure table 
behavior, like the de
 | write.metadata.metrics.column.col1                   | (not set)             
      | Metrics mode for column 'col1' to allow per-column tuning; none, 
counts, truncate(length), or full                                               
                                                 |
 | write.target-file-size-bytes                         | 536870912 (512 MB)    
      | Controls the size of files generated to target about this many bytes    
                                                                                
                                          |
 | write.delete.target-file-size-bytes                  | 67108864 (64 MB)      
      | Controls the size of delete files generated to target about this many 
bytes                                                                           
                                            |
-| write.distribution-mode                              | none                  
      | Defines distribution of write data: __none__: don't shuffle rows; 
__hash__: hash distribute by partition key ; __range__: range distribute by 
partition key or sort key if table has an SortOrder |
+| write.distribution-mode                              | hash                  
      | Defines distribution of write data: __none__: don't shuffle rows; 
__hash__: hash distribute by partition key ; __range__: range distribute by 
partition key or sort key if table has an SortOrder |

Review Comment:
   Shall we document this in the description and leave the default value as 
none.
   
   > Defines distribution of write data: none: don’t shuffle rows; hash: hash 
distribute by partition key ; range: range distribute by partition key or sort 
key if table has an SortOrder. Default value **none** for unpartitioned table, 
**hash** for partitioned table and **range** for sorted table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to