rdblue commented on code in PR #6884:
URL: https://github.com/apache/iceberg/pull/6884#discussion_r1320864979


##########
core/src/main/java/org/apache/iceberg/encryption/PlaintextEncryptionManager.java:
##########
@@ -18,15 +18,19 @@
  */
 package org.apache.iceberg.encryption;
 
-import java.nio.ByteBuffer;
 import org.apache.iceberg.io.InputFile;
 import org.apache.iceberg.io.OutputFile;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class PlaintextEncryptionManager implements EncryptionManager {
+  private static final EncryptionManager INSTANCE = new 
PlaintextEncryptionManager();

Review Comment:
   Can you also deprecate the public constructor so that we can remove it in 
1.6.0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to