rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1320871967
##########
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedOutputFile.java:
##########
@@ -24,10 +24,19 @@ class BaseEncryptedOutputFile implements
EncryptedOutputFile {
private final OutputFile encryptingOutputFile;
private final EncryptionKeyMetadata keyMetadata;
+ private final OutputFile rawOutputFile;
BaseEncryptedOutputFile(OutputFile encryptingOutputFile,
EncryptionKeyMetadata keyMetadata) {
+ this(encryptingOutputFile, keyMetadata, encryptingOutputFile);
+ }
+
+ BaseEncryptedOutputFile(
+ OutputFile encryptingOutputFile,
+ EncryptionKeyMetadata keyMetadata,
+ OutputFile rawOutputFile) {
Review Comment:
I was considering this when looking at #6884. `EncryptedOutputFile`
definitely needs to be able to return the underlying stream for Parquet
encryption, but that doesn't mean that `BaseEncryptedInputFile` necessarily has
to be used here.
Overall, I'm fine with this but it does look odd to have a wrapper that can
supply either the raw output file or an encrypted one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
