jerqi commented on code in PR #8428:
URL: https://github.com/apache/iceberg/pull/8428#discussion_r1322345878
##########
core/src/main/java/org/apache/iceberg/PositionDeletesTable.java:
##########
@@ -93,6 +95,16 @@ public Map<Integer, PartitionSpec> specs() {
return specs;
}
+ @Override
+ public Map<String, String> properties() {
+ // The write properties are needed by PositionDeletesRewriteAction,
+ // these properties should respect the ones of BaseTable.
+ return Collections.unmodifiableMap(
+ table().properties().entrySet().stream()
+ .filter(entry -> entry.getKey().startsWith("write."))
Review Comment:
I find that all the write properties are needed for our
PositionDeletesRewriteAction. So I choose to match the key prefix here
instead of giving a fixed collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
