sandflee commented on code in PR #8519:
URL: https://github.com/apache/iceberg/pull/8519#discussion_r1323238200
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -347,8 +347,12 @@ public <T extends RESTResponse> T handleRequest(
case LOAD_TABLE:
{
+ RESTSessionCatalog.SnapshotMode snapshotMode =
+ RESTSessionCatalog.SnapshotMode.valueOf(
+ PropertyUtil.propertyAsString(
+ vars, "snapshots",
RESTSessionCatalog.SnapshotMode.ALL.name()));
Review Comment:
`snapshot-loading-mode` is the property name in `RESTSessionCatalog` to init
snapshotMode. `snapshots` is the name of queryParams when REST client sending
requests.
```java
enum SnapshotMode {
ALL,
REFS;
// REST clients use it as queryParams
Map<String, String> params() {
return ImmutableMap.of("snapshots",
this.name().toLowerCase(Locale.US));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
