pvary commented on code in PR #8547:
URL: https://github.com/apache/iceberg/pull/8547#discussion_r1324729837
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommitLocks.java:
##########
@@ -202,6 +205,7 @@ public void testLockAcquisitionAfterFailedNotFoundLock()
throws TException, Inte
spyOps.doCommit(metadataV2, metadataV1);
+ verify(spyClient).showLocks(any()); // Make sure HiveLock's findLock
method is called
Review Comment:
Could we please add `times(1)`, as it is a bit more specific what we expect:
```
verify(spyClient, times(1)).showLocks(any())
```
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommitLocks.java:
##########
@@ -226,6 +230,7 @@ public void testLockAcquisitionAfterFailedAndFoundLock()
throws TException, Inte
spyOps.doCommit(metadataV2, metadataV1);
+ verify(spyClient).showLocks(any()); // Make sure HiveLock's findLock
method is called
Review Comment:
Could we please add `times(1)`, as it is a bit more specific what we expect:
```
verify(spyClient, times(1)).showLocks(any())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
