aokolnychyi commented on code in PR #8466:
URL: https://github.com/apache/iceberg/pull/8466#discussion_r1325365269
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -59,12 +59,17 @@ public VectorHolder(
// Only used for returning dummy holder
private VectorHolder() {
+ this(null);
Review Comment:
Exposing fields directly would cause a checkstyle violation. I feel the
current approach is simple enough.
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -59,12 +59,17 @@ public VectorHolder(
// Only used for returning dummy holder
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
