pvary commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1325754483
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -149,6 +156,12 @@ public void initializeState(StateInitializationContext
context) throws Exception
// Open the table loader and load the table.
this.tableLoader.open();
this.table = tableLoader.loadTable();
+ if (reloadIntervalMs > 0) {
+ this.tableSupplier = new ReloadingTableSupplier(table, tableLoader,
reloadIntervalMs);
Review Comment:
Why do not get the `tableSupplier` from outside? Why do we create it here
and in the `FlinkSink` as well?
QQ: What is the difference between the functionality of the `TableLoader`
and the `TableSupplier`? Is it just a TableLoader with cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
