ConeyLiu commented on code in PR #8560:
URL: https://github.com/apache/iceberg/pull/8560#discussion_r1325980307
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -395,6 +395,37 @@ public void
testRewriteDataFilesWithFilterOnPartitionTable() {
assertEquals("Data after compaction should not change", expectedRecords,
actualRecords);
}
+ @Test
+ public void testRewriteDataFilesWithFilterOnOnBucketExpression() {
+ // The schema `system` cannot be found in spark_catalog
+
Assume.assumeFalse(catalogName.equals(SparkCatalogConfig.SPARK.catalogName()));
+ createBucketPartitionTable();
Review Comment:
Same here, maybe we could use the test utils class
SystemFunctionPushDownHelper to build the table and data as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
