pvary commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1326995506
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -131,13 +134,15 @@ class IcebergFilesCommitter extends
AbstractStreamOperator<Void>
Map<String, String> snapshotProperties,
Integer workerPoolSize,
String branch,
- PartitionSpec spec) {
+ PartitionSpec spec,
+ long minReloadIntervalMs) {
this.tableLoader = tableLoader;
this.replacePartitions = replacePartitions;
this.snapshotProperties = snapshotProperties;
this.workerPoolSize = workerPoolSize;
this.branch = branch;
this.spec = spec;
+ this.minReloadIntervalMs = minReloadIntervalMs;
Review Comment:
My comment might be lost somewhere, but I think it would be better to
receive the TableSupplier here, instead of creating a new "incidentally" same
supplier than we do in the FlinkSink.
Also seeing the TableLoader/TableSupplier in one place mad me think how do
we separate the functionality of the 2. Do we really need 2 objects
providing/reloading tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
