amogh-jahagirdar commented on code in PR #8570:
URL: https://github.com/apache/iceberg/pull/8570#discussion_r1327900746
##########
python/pyiceberg/cli/output.py:
##########
@@ -127,6 +128,33 @@ def describe_table(self, table: Table) -> None:
output_table.add_row("Properties", table_properties)
Console().print(output_table)
+ def describe_refs(self, ref_tups: List[Tuple[str, SnapshotRef]]):
+ refs_table = RichTable(title="Snapshot Refs")
+ refs_table.add_column("Type")
+ refs_table.add_column("Ref")
+ refs_table.add_column("Max ref age ms")
+ refs_table.add_column("Min snapshots to keep")
+ refs_table.add_column("Max snapshot age ms")
+
+ for ref_tup in ref_tups:
+ name = ref_tup[0]
+ ref = ref_tup[1]
+ if ref.snapshot_ref_type == 'branch':
+ min_snapshots_to_keep = str(ref.min_snapshots_to_keep)
Review Comment:
Still thinking through what's best to surface to a user when the retention
properties aren't set. I wonder if the current outputting of "None" will
confuse users into thinking somehow there isn't any retention but that's not
really the case. During snapshot expiration we fall back to the table level
property. Maybe I just load the table property to fill in these values in case
it's None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
