rdblue commented on code in PR #8520:
URL: https://github.com/apache/iceberg/pull/8520#discussion_r1330618046
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -421,6 +421,7 @@ private void commitSimpleTransaction() {
.onlyRetryOn(CommitFailedException.class)
.run(
underlyingOps -> {
+ deletedFiles.clear();
Review Comment:
It's not safe to do this here because this will clear before the first
commit. `applyUpdates` will not re-commit everything on the first commit
because those are already completed. Instead I think this needs to be called
within `applyUpdates` just before all operations are re-committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
