aokolnychyi commented on code in PR #8446:
URL: https://github.com/apache/iceberg/pull/8446#discussion_r1330659957
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java:
##########
@@ -178,6 +182,10 @@ public static Expression convert(Filter filter) {
// col NOT IN (1, 2) in Spark is equivalent to notNull(col) &&
notIn(col, 1, 2) in
// Iceberg
In childInFilter = (In) childFilter;
+ if (Stream.of(childInFilter.values()).anyMatch(Objects::isNull)) {
Review Comment:
If we want to be safer and not support such NOT IN predicates, I can
understand that. I am not yet convinced about IN predicates, however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
