Fokko commented on code in PR #8558:
URL: https://github.com/apache/iceberg/pull/8558#discussion_r1332158553
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -600,3 +600,7 @@ def _get_updated_props_and_update_summary(
)
return properties_update_summary, updated_properties
+
+ def __repr__(self) -> str:
+ """Returns the string representation of the Catalog class."""
+ return f"{self.__class__} with name: {self.name} and properties:
{self.properties}"
Review Comment:
I think this is great, but I'm hesitant to print the properties as well
because it might expose credentials that might end up in logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
