y0psolo commented on PR #62: URL: https://github.com/apache/iceberg-rust/pull/62#issuecomment-1735065897
Thanks for your feedback :) ! I will add a validation function to the builder, seems logical. From my point of view it should validate the inner field of the TableMetadata but not the inner struct that should be validated when build with their own builder (Schema, ...). I see also that you prefer to have a valid random generated UUID by default. I asked myself the question, i have now the answer. I could also see if we can add an additional method to the builder (i think it's possible) to handle TableCreation struct. Something like `with_table_creation`. I will update the pull request to have new discussion materials. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
