mahdibh commented on issue #8642: URL: https://github.com/apache/iceberg/issues/8642#issuecomment-1735852931
I think the lack of consistency is problematic (breaks the principle of least surprise). I'm not super familiar with iceberg internals, but here is one way that this issue could be addressed while still properly dealing with #218 1. when specifying a delete handler on any of the `Transaction` methods returning an implementation of `SnapshotUpdate`, the `Transaction` implementation will store that on the side and precondition that the instance is unique across the various methods. This enforces a single custom delete handler for all the operation which seems like a reasonable requirement for a `Transaction`. Another option is that the handler can be set on the `Transaction` object which may seem more natural (ie, you can only set it on the transaction but you can't set it on individual operations). 2. the current implementation will call the handler on the final `Set<String>` of files that need to be deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
