rdblue commented on code in PR #8621:
URL: https://github.com/apache/iceberg/pull/8621#discussion_r1337589156
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -174,12 +174,17 @@ public long targetDataFileSize() {
.parse();
}
- public boolean fanoutWriterEnabled() {
+ public boolean useFanoutWriter(SparkWriteRequirements writeRequirements) {
+ boolean defaultValue = !writeRequirements.hasOrdering();
+ return useFanoutWriter(defaultValue);
+ }
+
+ private boolean useFanoutWriter(boolean defaultValue) {
Review Comment:
I think it's good to have `useFanoutWriter(SparkWriteRequirements)`, but
this method breaks the API convention of avoiding confusing boolean arguments.
For example, the method may return `true` when called as
`useFanoutWriter(false)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
