rdblue commented on code in PR #7880:
URL: https://github.com/apache/iceberg/pull/7880#discussion_r1337881947
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -291,6 +296,19 @@ private int addVersionInternal(ViewVersion version) {
return newVersionId;
}
+ /**
+ * @param version The view version to analyze
+ * @return A map of SQL dialect to its frequency in the list of
representations for the given
+ * view version
+ */
+ private Map<String, Long> sqlDialectFrequency(ViewVersion version) {
+ return version.representations().stream()
+ .filter(v -> v instanceof SQLViewRepresentation)
Review Comment:
This is usually nicer with a method reference:
```java
someList.stream()
.filter(ElementType.class::isInstance)
.map(ElementType.class::cast)
.map(ElementType::methodCall)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
