pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1338395742
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/RecordEmitterFactory.java:
##########
@@ -18,19 +18,14 @@
*/
package org.apache.iceberg.flink.source.reader;
-import org.apache.flink.api.connector.source.SourceOutput;
+import java.io.Serializable;
import org.apache.flink.connector.base.source.reader.RecordEmitter;
import org.apache.iceberg.flink.source.split.IcebergSourceSplit;
-final class IcebergSourceRecordEmitter<T>
- implements RecordEmitter<RecordAndPosition<T>, T, IcebergSourceSplit> {
-
- IcebergSourceRecordEmitter() {}
-
- @Override
- public void emitRecord(
- RecordAndPosition<T> element, SourceOutput<T> output, IcebergSourceSplit
split) {
- output.collect(element.record());
- split.updatePosition(element.fileOffset(), element.recordOffset());
- }
+/**
+ * Factory defining which {@link
org.apache.flink.connector.base.source.reader.RecordEmitter}
+ * implementation to use.
+ */
+public interface RecordEmitterFactory<T> extends Serializable {
+ RecordEmitter<RecordAndPosition<T>, T, IcebergSourceSplit> emitter();
Review Comment:
please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
