singhpk234 commented on code in PR #8370:
URL: https://github.com/apache/iceberg/pull/8370#discussion_r1339251585
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -84,9 +92,9 @@ public class S3FileIOProperties implements Serializable {
public static final String SSE_TYPE_CUSTOM = "custom";
/**
- * If S3 encryption type is SSE-KMS, input is a KMS Key ID or ARN. In case
this property is not
- * set, default key "aws/s3" is used. If encryption type is SSE-C, input is
a custom base-64
- * AES256 symmetric key.
+ * If S3 encryption type is SSE-KMS or DSSE-KMS, input is a KMS Key ID or
ARN. In case this
Review Comment:
I see what i meant here was the comment describe an if else structure which
makes it a bit hard to follow was wondering if we can re-write this comment in
such as way that it's easy for a user to understand / read it.
This is just a nit and not a blocking comment, as you are just adding a
disjunstion to an already existing if branch. please feel free to ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
