sudssf commented on a change in pull request #1046:
URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428785240



##########
File path: core/src/main/java/org/apache/iceberg/avro/GenericAvroWriter.java
##########
@@ -133,4 +141,38 @@ private WriteBuilder() {
       }
     }
   }
+
+  public static class UnionSchemaWriter<V extends Object> implements 
ValueWriter<V> {

Review comment:
       correct, 
   since iceberg does not support union type but avro does, this approach is 
similar to spark-avro where union types are converted to record.
   I dont think it make sense to support union types as it will mean adding 
support in schema for that which is larger change and has more blast radius.
   spark does not support union types so it make sense to align with spark and 
keep scope limited IMO




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to