amogh-jahagirdar commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1347419881
##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -92,7 +92,7 @@ public GenericManifestFile(Schema avroSchema) {
this.specId = specId;
this.sequenceNumber = 0;
this.minSequenceNumber = 0;
- this.snapshotId = null;
+ this.snapshotId = 0L;
Review Comment:
This seems a bit dangerous to me. I get we're saying it's required, so we
don't need the null value but I looked around to see where
manifestFile.snapshotId() == null checks are performed, and there's quite a
few. For example `RewriteDataFiles`, `AppendFiles`. This may break some of the
existing logic there by exercising the other branch in the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
