aokolnychyi commented on pull request #1052:
URL:
https://github.com/apache/incubator-iceberg/pull/1052#issuecomment-632810615
Yeah, I've seen this problem but didn't get time to fix it. Thanks,
@jerryshao.
I believe the problem is not about having a qualified path. The problem is
about not having a scheme in the table's location. I believe `LocationProvider`
will use the table location as a basis to generate a qualified location for
each new file. However, those locations will not have a scheme if the root
table location does not have it.
That's why I am not sure how this UDF will help us:
```
private static final UserDefinedFunction filename = functions.udf((String
path) -> {
int lastIndex = path.lastIndexOf(File.separator);
if (lastIndex == -1) {
return path;
} else {
return path.substring(lastIndex + 1);
}
}, DataTypes.StringType);
```
Also, switching to `contains` means using `BroadcastNestedLoopJoin`. This
action is already very expensive for large tables. I worry it wouldn't complete
now at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
