rdblue commented on a change in pull request #199:
URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429439746
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -65,10 +65,28 @@ public String name() {
public TypeDescription type() {
return type;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ OrcField orcField = (OrcField) o;
+ return Objects.equals(name, orcField.name) && Objects.equals(type,
orcField.type);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(name, type);
+ }
}
- private static final String ICEBERG_ID_ATTRIBUTE = "iceberg.id";
- private static final String ICEBERG_REQUIRED_ATTRIBUTE = "iceberg.required";
+ static final String ICEBERG_ID_ATTRIBUTE = "iceberg.id";
+ static final String ICEBERG_REQUIRED_ATTRIBUTE = "iceberg.required";
Review comment:
I don't see where these are used outside of this class. Why make the
package-private instead of private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
