chenjunjiedada commented on a change in pull request #830:
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r429510522
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -393,6 +396,16 @@ public ReadBuilder recordsPerBatch(int numRowsPerBatch) {
return this;
}
+ public ReadBuilder withNameMapping(NameMapping newNameMapping) {
+ this.nameMapping = newNameMapping;
+ return this;
+ }
+
+ public ReadBuilder applyNameMapping() {
Review comment:
The idea is if there is no name mapping supplied, we use a default name
mapping build from table schema.
I 'm still a bit confused that why we would allow users to pass in a
customized name mapping. IMHO, there are only two name mappings should be
legal, either we create it from parquet file or we create it from the table
schema. Is there any scenario that user would pass in other mappings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
