ajantha-bhat commented on code in PR #8966: URL: https://github.com/apache/iceberg/pull/8966#discussion_r1378650407
########## format/view-spec.md: ########## @@ -243,7 +243,7 @@ Each change creates a new metadata JSON file. ```sql USE prod.other_db; CREATE OR REPLACE VIEW default.event_agg ( - event_count, + event_count COMMENT 'Count of events', Review Comment: When compared this to line 175-177, column comment and view comment both were missing. But this change was not reflected back in the new metadata file. - I updated the metadata file to remove properties. Since view comment is missing. - Instead of adding a new schema id with missing doc, I added back the column comment to simplify the example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
