fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1393512136
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, used for garbage
/// collection and table inspection
- timestamp_ms: i64,
+ timestamp_ms: Timestamp,
Review Comment:
Was not aware of any of this history, thanks!
> return chrono types as public api.
If I'm understanding correctly, it sounds like we only want to modify APIs
marked as `pub`, `pub(crate)`, `pub(super)`, etc. so that they return a
`DateTime<Utc>` instead of `i64`.
If so, the latest
[commit](https://github.com/apache/iceberg-rust/pull/94/commits/9521da820f14fc0383c65128b368a5764ed028b5)
should address these concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
