pvary commented on PR #9151: URL: https://github.com/apache/iceberg/pull/9151#issuecomment-1827633516
> Hi @pvary, thanks for the review. Just to clarify, is this PR consider clean backport? If you just have to apply the Flink v1.17 changes to the v1.16, v1.15 folder, and you do not need to change anything then it is a clean backport. If you need to do some changes, because the old Flink version does not support some feature needed by the change, then it is not a clean backport I generate the backport patches like this: ``` git diff HEAD^ |sed -e "s/v1.17/v1.15/g" > 1.15.patch ``` > I will try my best to move the junit 4 tests to 5 😃 There are plenty of Flink tests which still uses junit4, so we will have tasks for a long while 😄 Thanks, Peter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
