nastra commented on code in PR #9049:
URL: https://github.com/apache/iceberg/pull/9049#discussion_r1416913245
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -507,4 +508,25 @@ public String toString() {
.map(this::identifierFieldToString)
.collect(Collectors.toList())));
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
Review Comment:
I would be cautious about defining equality for Schema. I'm sure there was a
reason why `Schema` and `TableMetadata` didn't implement equals() / hashCode().
I think it would be good to get the opinion of @rdblue here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
