rdblue commented on pull request #828:
URL: https://github.com/apache/iceberg/pull/828#issuecomment-638492478


   I just tried changing the batch size passed to create the reader:
   
   ```java
   VectorizedSparkParquetReaders.buildReader(schema, type, 10001)
   ```
   
   That caused tests to fail with "Number of values read, 10001, does not equal 
expected, 10000". Batches should be allocated based on the value passed in by 
read, not configuration on the reader. We should also add a test for this case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to